iam_role_info - fix bug in prefix_path handling of missing /s #2066
Conversation
|
@vonschultz many thanks for catching this and tracking down the cause, I'm guessing 7.5.0 caused something to break for you for which I apologise. In future, if the original PR has already been merged it's a better idea to open a new issue, rather than review a merged PR. It's very easy to miss comments on an old merged PR, if I happened to have marked the notification email as read your review would be almost impossible to spot. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 29s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 30s |
softwarefactory-project-zuul
bot
merged commit a92f03a
into
ansible-collections:main
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #2069 🤖 @patchback |
iam_role_info - fix bug in prefix_path handling of missing /s SUMMARY fixes: #2065 When updating the code in iam_role_info to handle missing / at the start/end of prefix_path, the string as finally built should be an f-string not a simple string/ ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role_info ADDITIONAL INFORMATION Thanks to vonschultz for catching this one. Reviewed-by: Alina Buzachis (cherry picked from commit a92f03a)
…2069) [PR #2066/a92f03ad backport][stable-7] iam_role_info - fix bug in prefix_path handling of missing /s This is a backport of PR #2066 as merged into main (a92f03a). SUMMARY fixes: #2065 When updating the code in iam_role_info to handle missing / at the start/end of prefix_path, the string as finally built should be an f-string not a simple string/ ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role_info ADDITIONAL INFORMATION Thanks to vonschultz for catching this one. Reviewed-by: Mark Chappell
…ollections#2066) iam_role_info - fix bug in prefix_path handling of missing /s SUMMARY fixes: ansible-collections#2065 When updating the code in iam_role_info to handle missing / at the start/end of prefix_path, the string as finally built should be an f-string not a simple string/ ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role_info ADDITIONAL INFORMATION Thanks to vonschultz for catching this one. Reviewed-by: Alina Buzachis
SUMMARY
fixes: #2065
When updating the code in iam_role_info to handle missing
/at the start/end of prefix_path, the string as finally built should be an f-string not a simple string/ISSUE TYPE
COMPONENT NAME
iam_role_info
ADDITIONAL INFORMATION
Thanks to vonschultz for catching this one.